| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1300703828-6291-1-git-send-email-amit.salecha@qlogic.com> Date: Mon, 21 Mar 2011 03:37:08 -0700 From: Amit Kumar Salecha <amit.salecha@...gic.com> To: davem@...emloft.net Cc: netdev@...r.kernel.org, ameen.rahman@...gic.com, Rajesh Borundia <rajesh.borundia@...gic.com> Subject: [PATCH] netxen: fix LRO disable warning netxen_nic_set_flags() rejects data if other flag than ETH_FLAG_LRO is set. Driver also supports NETIF_F_HW_VLAN_TX. Now compare data with ethtool_op_get_flags(), to get all supported features. Reported-by: Jesper Dangaard Brouer <jdb@...x.dk> Signed-off-by: Rajesh Borundia <rajesh.borundia@...gic.com> Signed-off-by: Amit Kumar Salecha <amit.salecha@...gic.com> --- drivers/net/netxen/netxen_nic_ethtool.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_ethtool.c b/drivers/net/netxen/netxen_nic_ethtool.c index 653d308..31c41d6 100644 --- a/drivers/net/netxen/netxen_nic_ethtool.c +++ b/drivers/net/netxen/netxen_nic_ethtool.c @@ -871,7 +871,8 @@ static int netxen_nic_set_flags(struct net_device *netdev, u32 data) struct netxen_adapter *adapter = netdev_priv(netdev); int hw_lro; - if (data & ~ETH_FLAG_LRO) + if ((ethtool_op_get_flags(netdev) & ~ETH_FLAG_LRO) != + (data & ~ETH_FLAG_LRO)) return -EINVAL; if (!(adapter->capabilities & NX_FW_CAPABILITY_HW_LRO)) -- 1.7.3.2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists