netdev - Re: [RFC] net: fix ethtool->set_flags not intended -EINVAL return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimiDBh=WzT91JbKnucNfJqDzJ8jTHvUobxQ0xk2@mail.gmail.com>
Date:	Mon, 21 Mar 2011 19:41:12 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	Amit Salecha <amit.salecha@...gic.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Jesper Dangaard Brouer <hawk@...x.dk>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	netdev <netdev@...r.kernel.org>,
	Neil Horman <nhorman@...driver.com>
Subject: Re: [RFC] net: fix ethtool->set_flags not intended -EINVAL return value

On Mon, Mar 21, 2011 at 8:10 AM, Stanislaw Gruszka <sgruszka@...hat.com> wrote:
> After commit d5dbda23804156ae6f35025ade5307a49d1db6d7 "ethtool: Add
> support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
> and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
> acceleration via ethtool set_flags, always return -EINVAL from that
> function. Fix by returning -EINVAL only if requested features do
> not match current settings and can not be changed by driver.

Looks good to me, thanks for fixing this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html