netdev - Re: [PATCH 3/4] drivers/net/fec: Fix dual MAC support on i.MX28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110322.010717.241446116.davem@davemloft.net>
Date:	Tue, 22 Mar 2011 01:07:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	LW@...O-electronics.de
Cc:	shawn.guo@...escale.com, netdev@...r.kernel.org,
	u.kleine-koenig@...gutronix.de
Subject: Re: [PATCH 3/4] drivers/net/fec: Fix dual MAC support on i.MX28

From: Lothar Waßmann <LW@...O-electronics.de>
Date: Tue, 22 Mar 2011 09:04:00 +0100

> Shawn Guo writes:
>> > +static int dual_mac;
>> > +module_param(dual_mac, int, S_IRUGO);
>> > +
>> 
>> As you are detecting dual_mac in probe function, is this necessary?
>> 
> Not really. I added this is only for debugging.

Please do not add driver-specific module parameters.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html