netdev - Re: [PATCH] net: davinci_emac:Fix translation logic for buffer descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D8875C1.9090004@mvista.com>
Date:	Tue, 22 Mar 2011 13:11:13 +0300
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Sriramakrishnan <srk@...com>
CC:	netdev@...r.kernel.org,
	davinci-linux-open-source@...ux.davincidsp.com, davem@...emloft.net
Subject: Re: [PATCH] net: davinci_emac:Fix translation logic for buffer descriptor

Hello.

On 22-03-2011 13:06, Sriramakrishnan wrote:

> With recent changes to the driver(switch to new cpdma layer),
> the support for buffer descriptor address translation logic
> is broken. This affects platforms where the physical address of
> the descriptors as seen by the DMA engine is different from the
> physical address.

> Original Patch adding translation logic support:
> Commit: ad021ae8862209864dc8ebd3b7d3a55ce84b9ea2

> Signed-off-by: Sriramakrishnan <srk@...com>

    AFAIK, full name is required for signoff.

[...]

> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 082d6ea..df850fc 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1854,10 +1854,13 @@ static int __devinit davinci_emac_probe(struct platform_device *pdev)
>   	dma_params.rxcp			= priv->emac_base + 0x660;
>   	dma_params.num_chan		= EMAC_MAX_TXRX_CHANNELS;
>   	dma_params.min_packet_size	= EMAC_DEF_MIN_ETHPKTSIZE;
> -	dma_params.desc_mem_phys	= hw_ram_addr;
> +	dma_params.desc_hw_addr		= hw_ram_addr;
>   	dma_params.desc_mem_size	= pdata->ctrl_ram_size;
>   	dma_params.desc_align		= 16;
>
> +	dma_params.desc_mem_phys = (pdata->no_bd_ram) ? 0 :

    Parens not needed here.

> +			((u32 __force)res->start + pdata->ctrl_ram_offset);

    Here either not necessary.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html