netdev - Re: [patch net-2.6] bonding: fix rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110323211559.GA2809@psychotron.redhat.com>
Date:	Wed, 23 Mar 2011 22:16:00 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, andy@...yhouse.net,
	fubar@...ibm.com
Subject: Re: [patch net-2.6] bonding: fix rx_handler locking

Wed, Mar 23, 2011 at 08:25:37PM CET, nicolas.2p.debian@...il.com wrote:
>Le 22/03/2011 13:38, Jiri Pirko a écrit :
>>This prevents possible race between bond_enslave and bond_handle_frame
>>as reported by Nicolas by moving rx_handler register/unregister.
>>slave->bond is added to hold pointer to master bonding sructure. That
>>way dev->master is no longer used in bond_handler_frame.
>>Also, this removes "BUG: scheduling while atomic" message
>>
>>Reported-by: Nicolas de Pesloüan<nicolas.2p.debian@...il.com>
>>Signed-off-by: Jiri Pirko<jpirko@...hat.com>
>
>Thanks Jiri, it works.
>
>Tested-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
>
>Regarding the code review, can you explain the reasons why you
>apparently duplicated the fields related to the slave/master
>relationship?
>
>Do you plan to totally remove dev->master usage in bonding in a follow-up patch?

dev->master could be possibly retired. Not sure yet. It's on my todo
list.
>
>	Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html