netdev - RE: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300895205.2638.0.camel@bwh-desktop>
Date:	Wed, 23 Mar 2011 15:46:45 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eugenia Emantayev <eugenia@...lanox.co.il>
Subject: RE: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

On Wed, 2011-03-23 at 15:10 +0000, Yevgeny Petrilin wrote:
> > 
> > This is an abuse of the ethtool_drvinfo::driver field.
> > 
> > Your users can use lspci -v, can't they?
> > 
> I don't think there is a problem here.
> We have always reported the HW model via Ethtool, we just expanded the information
> we provide.
> Our users prefer to see the information in ethtool.

Do you mean 'we documented ethtool -i as the way to get hardware
identification'?  That would be a bug in your documentation.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html