netdev - RE: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <953B660C027164448AE903364AC447D20705C16E@mtldag01.mtl.com>
Date:	Thu, 24 Mar 2011 06:26:22 +0000
From:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eugenia Emantayev <eugenia@...lanox.co.il>
Subject: RE: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

I will send the patch removing the HW information.

Yevgeny

> -----Original Message-----
> From: Ben Hutchings [mailto:bhutchings@...arflare.com]
> Sent: Thursday, March 24, 2011 5:40 AM
> To: Yevgeny Petrilin
> Cc: davem@...emloft.net; netdev@...r.kernel.org; Eugenia Emantayev
> Subject: RE: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool
> -i
> 
> On Wed, 2011-03-23 at 15:10 +0000, Yevgeny Petrilin wrote:
> > >
> > > This is an abuse of the ethtool_drvinfo::driver field.
> > >
> > > Your users can use lspci -v, can't they?
> > >
> > I don't think there is a problem here.
> > We have always reported the HW model via Ethtool, we just expanded
> the information
> > we provide.
> > Our users prefer to see the information in ethtool.
> 
> I can provide a patch for David if you won't.
> 
> Ben.
> 
> --
> Ben Hutchings, Senior Software Engineer, Solarflare Communications
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.