netdev - Re: [PATCH resend] can: c_can: Fix tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D8B2FAF.5040000@grandegger.com>
Date:	Thu, 24 Mar 2011 12:49:03 +0100
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Jan Altenberg <jan@...utronix.de>,
	Bhupesh SHARMA <bhupesh.sharma@...com>,
	"b.spranger@...utronix.de" <b.spranger@...utronix.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Socketcan-core@...ts.berlios.de" <Socketcan-core@...ts.berlios.de>
Subject: Re: [PATCH resend] can: c_can: Fix tx_bytes accounting

On 03/24/2011 11:49 AM, Kurt Van Dijck wrote:
> On Thu, Mar 24, 2011 at 12:26:50PM +0100, Jan Altenberg wrote:
>> The current SocketCAN implementation for the Bosch c_can cell doesn't
>> account the TX bytes correctly, because it calls
>> c_can_inval_msg_object() (which clears the msg ctrl register) before
>> reading the DLC value:
>>
>> The fix is quite easy: Just move c_can_inval_msg_object() to the end of
>> the if() statement. So:
>>       * We only call c_can_inval_msg_object() if the message was
>>         actually transmitted
>>       * We read out the DLC value _before_ clearing the msg ctrl
>>         register
>>
>> Signed-off-by: Jan Altenberg <jan@...utronix.de>
> Acked-by: Kurt Van Dijck <kurt.van.dijck@....be>
Acked-by: Wolfgang Grandegger <wg@...ndegger.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html