netdev - Re: [RFC PATCH] et1011c: Replaced PHY driver by a small dm646x board fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Mar 2011 19:24:04 -0500
From:	Andy Fleming <afleming@...il.com>
To:	Kyle Moffett <Kyle.D.Moffett@...ing.com>
Cc:	netdev@...r.kernel.org, Kevin Hilman <khilman@...prootsystems.com>,
	Russell King <linux@....linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	"David J. Choi" <david.choi@...rel.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] et1011c: Replaced PHY driver by a small dm646x board fixup

On Wed, Mar 23, 2011 at 5:33 PM, Kyle Moffett <Kyle.D.Moffett@...ing.com> wrote:

> -
> -static struct phy_driver et1011c_driver = {
> -       .phy_id         = 0x0282f014,
> -       .name           = "ET1011C",
> -       .phy_id_mask    = 0xfffffff0,
> -       .features       = (PHY_BASIC_FEATURES | SUPPORTED_1000baseT_Full),
> -       .flags          = PHY_POLL,
> -       .config_aneg    = et1011c_config_aneg,
> -       .read_status    = et1011c_read_status,
> -       .driver         = { .owner = THIS_MODULE,},
> -};


Might I suggest that you not eliminate the whole driver?  If you leave
just this part (and the init stuff below it), and convert the
config_aneg and read_status pointers to use the genphy versions, the
kernel will, at least, be able to report what type of PHY it is.  And
maybe one day, someone who is familiar with the inner workings of this
PHY will fill in a more correct driver.

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html