netdev - Re: [RFC] usbnet: use eth%d name for known ethernet devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Mar 2011 18:20:44 +0100
From:	Alexey Orishko <alexey.orishko@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	Steve Calfee <stevecalfee@...il.com>,
	Michal Nazarewicz <mnazarewicz@...il.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	broonie@...nsource.wolfsonmicro.com,
	lkml <linux-kernel@...r.kernel.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Greg KH <greg@...ah.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, grant.likely@...retlab.ca,
	Linux USB list <linux-usb@...r.kernel.org>,
	andy.green@...aro.org, netdev@...r.kernel.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	roger.quadros@...ia.com,
	Jaswinder Singh <jaswinder.singh@...aro.org>,
	patches@...aro.org
Subject: Re: [RFC] usbnet: use eth%d name for known ethernet devices

On Thu, Mar 24, 2011 at 2:15 PM, Arnd Bergmann <arnd@...db.de> wrote:

>
> The approach taken here is to flag whether a device might be a
> point-to-point link with the new FLAG_PTP setting in the usbnet
> driver_info. A driver can set both FLAG_PTP and FLAG_ETHER if
> it is not sure (e.g. cdc_ether), or just one of the two.

> The usbnet framework only looks at the MAC address for device
> naming if both flags are set, otherwise it trusts the flag.

Should this paragraph above be a clue for the flag name?
Sorry for late comment, but having flag called FLAG_POINTTOPOINT is really
confusing. ptp, p2p terms are heavily used and will mislead folks.

Would it be better to call it something like IGNORE_MAC_ADDRESS if this is the
feature you are targeting?

/Alexey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html