netdev - Re: [PATCH] Fix IP timestamp option (IPOPT_TS_PRESPEC) handling in ip_options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110324.162005.71589730.davem@davemloft.net>
Date:	Thu, 24 Mar 2011 16:20:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jluebbe@...ian.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix IP timestamp option (IPOPT_TS_PRESPEC) handling in
 ip_options_echo()

From: Jan Luebbe <jluebbe@...ian.org>
Date: Thu, 24 Mar 2011 18:44:22 +0100

> -					if (soffset + 8 <= optlen) {
> +					if (soffset + 7 <= optlen) {

I don't see how you can legally reduce this check from 8 to 7 bytes.

> +						if (inet_addr_type(dev_net(skb_dst(skb)->dev), addr) != RTN_UNICAST) {
>  							dopt->ts_needtime = 1;
>  							soffset += 8;
>  						}

Yet keep this code which advances soffset by 8.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html