netdev - Re: [PATCH] net: allow shifted address in smsc911x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110325.143103.25112180.davem@davemloft.net>
Date:	Fri, 25 Mar 2011 14:31:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mathieu.poirier@...aro.org
Cc:	steve.glendinning@...c.com, netdev@...r.kernel.org,
	lee.jones@...aro.org, patches@...aro.org, linus.walleij@...aro.org
Subject: Re: [PATCH] net: allow shifted address in smsc911x

From: mathieu.poirier@...aro.org
Date: Fri, 25 Mar 2011 15:27:17 -0600

> From: Alessandro Rubini <rubini@...dd.com>
> 
> At least one device I'm using needs address shifting to access
> registers in the LAN9221 device (smsc911x driver).  This patch
> adds a shift parameter in platform_data. The feature must be
> enabled at configuration time, because shifting by a pdata
> parameter makes access slower in those devices where no shift is
> needed (I tested one, it was 20% slower).
> 
> If the platform data requests shifted access but the feature is
> unavailable, the probe method complains to the console. Board
> config files should set the configuration option when needed.
> 
> Signed-off-by: Alessandro Rubini <rubini@...dd.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>

Implement this at run time, keying off of a boolean or similar
in the platform data.

Implement a set of ops, one to do a PIO read one to do a PIO write,
and choose the set of ops appropriate for the device depending upon
the setting found in the platform device.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html