netdev - Re: [PATCH] bridge: mcast snooping, fix IPv6 MLD checksum calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110327075242.GA24677@gondor.apana.org.au>
Date:	Sun, 27 Mar 2011 15:52:42 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Linus Lüssing <linus.luessing@....de>
Cc:	bridge@...ts.linux-foundation.org,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: mcast snooping, fix IPv6 MLD checksum
	calculation

On Sun, Mar 27, 2011 at 09:06:45AM +0200, Linus Lüssing wrote:
> So instead of 'if (!csum_fold(skb2->csum))' it should be this?
> ---
> if (!csum_ipv6_magic(&ip6h->saddr, &ip6h->daddr,
>                      skb2->len, nexthdr, skb2->csum))
> ---
> (I'm peeking a little bit at
> http://lxr.linux.no/linux+*/net/ipv6/netfilter.c#L98)

Yes that looks about right.

> Hmm, if so, then I don't know how to test and verify that now though.

You'd need a NIC that supported this to test.  Although I wouldn't
worry about it too much as the same code patterns appears over and
over again in our stack.  Perhaps we should put it in a helper.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html