netdev - Re: [PATCH 2/3] tg3: Don't use IRQF_SAMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110327030830.GF1885@bicker>
Date:	Sun, 27 Mar 2011 06:08:30 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Javier Martinez Canillas <martinez.javier@...il.com>
Cc:	Matt Carlson <mcarlson@...adcom.com>,
	Michael Chan <mchan@...adcom.com>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/3] tg3: Don't use IRQF_SAMPLE_RANDOM

On Sun, Mar 27, 2011 at 04:42:32AM +0200, Javier Martinez Canillas wrote:
> This flag is scheduled for removal so we shouldn't used it.
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>
> ---
>  drivers/net/tg3.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index c67eb19..58c6049 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -8844,12 +8844,11 @@ static int tg3_request_irq(struct tg3 *tp, int irq_num)
>  		fn = tg3_msi;
>  		if (tp->tg3_flags2 & TG3_FLG2_1SHOT_MSI)
>  			fn = tg3_msi_1shot;
> -		flags = IRQF_SAMPLE_RANDOM;

You need initialize flags to zero here.  Apparently gcc doesn't catch
this.  I'm using gcc 4.4.3-4ubuntu5.

regards,
dan carpenter
v
>  	} else {
>  		fn = tg3_interrupt;
>  		if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS)
>  			fn = tg3_interrupt_tagged;
> -		flags = IRQF_SHARED | IRQF_SAMPLE_RANDOM;
> +		flags = IRQF_SHARED;
>  	}
>  
>  	return request_irq(tnapi->irq_vec, fn, flags, name, tnapi);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html