netdev - Re: [PATCH] net: fix ethtool->set_flags not intended -EINVAL return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110328144837.GB4037@redhat.com>
Date:	Mon, 28 Mar 2011 16:48:37 +0200
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Jon Mason <jdmason@...zu.us>
Cc:	netdev@...r.kernel.org, Ben Hutchings <bhutchings@...arflare.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Jesse Gross <jesse@...ira.com>,
	Amit Kumar Salecha <amit.salecha@...gic.com>,
	Shreyas Bhatewara <sbhatewara@...are.com>,
	Jesper Dangaard Brouer <hawk@...x.dk>
Subject: Re: [PATCH] net: fix ethtool->set_flags not intended -EINVAL return
 value

On Mon, Mar 28, 2011 at 09:21:57AM -0500, Jon Mason wrote:
> > -	if (data & ~ETH_FLAG_RXHASH)
> > -		return -EOPNOTSUPP;
> > +	if (ethtool_invalid_flags(dev, data, ETH_FLAG_RXHASH))
> > +		return -EINVAL;
> 
> The return code value is being changed, which is not relevant to this
> patch.  Perhaps a secondary patch should be created to make all driver
> set_flags calls return EOPNOTSUPP for unsupported flag setting.

Linux network developers agree some time ago that EINVAL should be used
in this case.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html