netdev - Re: [PATCH 2/2 v2] tg3: Don't use IRQF_SAMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201103282208.05830.ffainelli@freebox.fr>
Date:	Mon, 28 Mar 2011 22:08:05 +0200
From:	Florian Fainelli <ffainelli@...ebox.fr>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Javier Martinez Canillas <martinez.javier@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>,
	Dan Carpenter <error27@...il.com>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2 v2] tg3: Don't use IRQF_SAMPLE_RANDOM

Hello,

On Monday 28 March 2011 19:20:22 Ben Hutchings wrote:
> On Mon, 2011-03-28 at 17:46 +0200, Javier Martinez Canillas wrote:
> > On Mon, Mar 28, 2011 at 2:25 PM, Eric Dumazet <eric.dumazet@...il.com> 
wrote:
> > > 1) We dont believe its Janitor material ;)
> > > 
> > > http://thread.gmane.org/gmane.linux.kernel/680723
> > > 
> > > http://kerneltrap.org/mailarchive/linux-netdev/2009/4/6/5417754
> > 
> > I wasn't aware of this discussion. In one hand network drivers are not
> > a good source of entropy because they can be controlled externally,
> > but in embedded systems with only network cards (no video, audio,
> > keyboard, etc) the only source of entropy they have is their network
> > cards (at the kernel level i.e: not using EGD to feed /dev/random).
> 
> It may be the only source of entropy, but given how poor a source it is
> these drivers are basically telling sweet little lies to the kernel and
> the applications that demand real random numbers.
> 
> This also applies to many servers just as much as embedded systems.

Indeed, this is the reason why bcm63xx_enet.c for instance contributes to the 
general entropy of the system, because it is used on MIPS based ADSL routers 
where we have little or no other source of entropy.

Still even poor entropy is better than none on such devices imho.

> 
> As you acknowledge, these systems can still get entropy using the EGD
> protocol over a secure channel.  (Or an entropy sampling device such as
> the Entropy Key.)



> 
> > Yes this definitely is not janitor material :)
> > 
> > I just sent the patch because I saw IRQF_SAMPLE_RANDOM in
> > Documentation/feature-removal-schedule.txt. I can resend a patch
> > removing the macro in the remaining network cards if the decision is
> > to remove IRQF_SAMPLE_RANDOM.
> 
> It's not my call, but I would support it.
> 
> Ben.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html