netdev - Re: [PATCH net-next] net-ethtool: Allow ethtool to set interface in loopback mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110329133941.GA15944@rere.qmqm.pl>
Date:	Tue, 29 Mar 2011 15:39:41 +0200
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Mahesh Bandewar <maheshb@...gle.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH net-next] net-ethtool: Allow ethtool to set interface
	in loopback mode.

On Tue, Mar 29, 2011 at 12:48:43AM +0100, Ben Hutchings wrote:
> I'm sorry that things keep changing under your feet.  Unfortunately I'm
> going to have to ask for more changes; see below.
> 
> I'm cc'ing Michał Mirosław so he can comment on how he thinks the
> generic feature handling should be extended.
> 
> On Mon, 2011-03-28 at 15:24 -0700, Mahesh Bandewar wrote:
> > Add second word for feature (currently it's single word). Also use the first
> > bit of the second word to set the loopback mode. By configuring the interface
> > in loopback mode in conjunction with a policy route / rule, a user-land
> > application can stress the egress / ingress path exposing the flows of the
> > change in progress and potentially help developer(s) understand the impact of
> > those changes without even sending a packet out on the network.

For one, adding more feature words should be separate patch to the one
introducing loopback mode.

Unless I missed some patches, there's still one or two bits left in features
you can use. This will be a lot less work for you.

As Ben already commented on the visible parts of the patch, I'll only add
what's missing in it.

Extending feature words will need at least:
 - adding new features word (making it an array will be a big patch unless
   it's doable with preprocessor hackery)
 - changing hw_features and wanted_features to arrays
 - extending ndo_fix/set_features to handle arrays instead of one word
 - updating bridge/vlan/bonding code to handle propagation of the extra words
   (I'm waiting for merge window to close to resend patches touching this
   for proper review)
 - extending netdev_features_strings[] to 32x count of words (or functions
   using it could be modified to handle missing entries at the end)

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html