netdev - Re: [PATCH] net: gre: provide multicast mappings for ipv4 and ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110330.001131.200365288.davem@davemloft.net>
Date:	Wed, 30 Mar 2011 00:11:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rdkehn@...oo.com
Cc:	netdev@...r.kernel.org, timo.teras@....fi
Subject: Re: [PATCH] net: gre: provide multicast mappings for ipv4 and ipv6

From: Doug Kehn <rdkehn@...oo.com>
Date: Tue, 29 Mar 2011 13:26:02 -0700 (PDT)

> 
> --- On Tue, 3/29/11, Timo Teräs <timo.teras@....fi> wrote:
> 
>> From: Timo Teräs <timo.teras@....fi>
>> Subject: [PATCH] net: gre: provide multicast mappings for ipv4 and ipv6
>> To: netdev@...r.kernel.org
>> Cc: "Doug Kehn" <rdkehn@...oo.com>, "Timo Teräs" <timo.teras@....fi>
>> Date: Tuesday, March 29, 2011, 4:40 AM
>> My commit 6d55cb91a0020ac0 (gre: fix
>> hard header destination
>> address checking) broke multicast.
>> 
>> The reason is that ip_gre used to get ipgre_header() calls
>> with
>> zero destination if we have NOARP or multicast destination.
>> Instead
>> the actual target was decided at ipgre_tunnel_xmit() time
>> based on
>> per-protocol dissection.
>> 
>> Instead of allowing the "abuse" of ->header() calls with
>> invalid
>> destination, this creates multicast mappings for ip_gre.
>> This also
>> fixes "ip neigh show nud noarp" to display the proper
>> multicast
>> mappings used by the gre device.
>> 
>> Reported-by: Doug Kehn <rdkehn@...oo.com>
>> Signed-off-by: Timo Teräs <timo.teras@....fi>
> 
> Acked-by: Doug Kehn <rdkehn@...oo.com>

Applied.

Timo, if updates are necessary for the ipv4 mapped handling in ipv6,
please send that as a follow-up fix.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html