netdev - Re: ethtool physical identify vs netlink locking?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110329.171328.28814158.davem@davemloft.net>
Date:	Tue, 29 Mar 2011 17:13:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: ethtool physical identify vs netlink locking?

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 30 Mar 2011 01:07:56 +0100

> In the sfc driver, physical ID used to be delegated to the PHY
> operations.  Then I realised that it was pointless to use a PHY's blink
> mode where it was available and a periodic timer on the host where it
> wasn't, when the latter would work for all of them.  So I would propose:
> 
> 4. Define a ethtool operation 'set_id_state' with an argument that sets
> identification on/off/inactive/active (the last optional, for any driver
> that really wants to do this differently).  When this is defined, the
> ethtool core runs the loop and acquires the lock each time it calls this
> operation.
> 
> This requires changes to every driver, though not all at once.  As an
> additional benefit, it should result in consistent behaviour for the
> count = 0 case.

This seems like a good way to solve the problem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html