netdev - Re: [PATCH] bridge: mcast snooping, fix length check of snooped MLDv1/2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110330.023001.13743450.davem@davemloft.net>
Date:	Wed, 30 Mar 2011 02:30:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linus.luessing@....de
Cc:	bridge@...ts.linux-foundation.org, shemminger@...ux-foundation.org,
	yoshfuji@...ux-ipv6.org, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: mcast snooping, fix length check of snooped
 MLDv1/2

From: Linus Lüssing <linus.luessing@....de>
Date: Sun, 27 Mar 2011 08:27:24 +0200

> "len = ntohs(ip6h->payload_len)" does not include the length of the ipv6
> header itself, which the rest of this function assumes, though.
> 
> This leads to a length check less restrictive as it should be in the
> following line for one thing. For another, it very likely leads to an
> integer underrun when substracting the offset and therefore to a very
> high new value of 'len' due to its unsignedness. This will ultimately
> lead to the pskb_trim_rcsum() practically never being called, even in
> the cases where it should.
> 
> Signed-off-by: Linus Lüssing <linus.luessing@....de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html