netdev - Re: [PATCH] smsc911x: Use pr_fmt, netdev_<level>, and netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110330.214307.63030538.davem@davemloft.net>
Date:	Wed, 30 Mar 2011 21:43:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	steve.glendinning@...c.com, jtp.park@...sung.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] smsc911x: Use pr_fmt, netdev_<level>, and netif_<level>

From: Joe Perches <joe@...ches.com>
Date: Fri, 25 Mar 2011 17:21:22 -0700

> Use the more common/verbose logging styles.
> 
> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Remove smsc911x prefixes from format strings.
> Rename SMSC_WARNING to SMSC_WARN.
> Remove DPRINTK macro.
> Use netif_<level> in SMSC_<level> macros.
> Convert NETIF_MSG_<foo> uses to lower case.
> Add no_printk verification in non-debug uses.
> Add pdata to SMSC_<level> uses to avoid hidden variable uses.
> Convert printks to netdev_<level> as appropriate.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html