netdev - [PATCH] net/bridge: Fix wrong return-no-vaule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1301631861-12470-1-git-send-email-namei.unix@gmail.com>
Date:	Fri,  1 Apr 2011 12:24:21 +0800
From:	namei.unix@...il.com
To:	shemminger@...ux-foundation.org, davem@...emloft.net
Cc:	Liu Yuan <tailai.ly@...bao.com>,
	bridge@...ts.linux-foundation.org (open list:ETHERNET BRIDGE),
	netdev@...r.kernel.org (open list:ETHERNET BRIDGE),
	linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] net/bridge: Fix wrong return-no-vaule

From: Liu Yuan <tailai.ly@...bao.com>

In br_stp_if.c/br_stp_recalculate_bridge_id, it should return
false, which indicates that there is no change when we find
that user has chosen a value.

Signed-off-by: Liu Yuan <tailai.ly@...bao.com>
---
 net/bridge/br_stp_if.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
index 5593f5a..9b61d09 100644
--- a/net/bridge/br_stp_if.c
+++ b/net/bridge/br_stp_if.c
@@ -213,7 +213,7 @@ bool br_stp_recalculate_bridge_id(struct net_bridge *br)
 
 	/* user has chosen a value so keep it */
 	if (br->flags & BR_SET_MAC_ADDR)
-		return;
+		return false;
 
 	list_for_each_entry(p, &br->port_list, list) {
 		if (addr == br_mac_zero ||
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html