netdev - Re: appletalk oops.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201104011626.22656.arnd@arndb.de>
Date:	Fri, 1 Apr 2011 16:26:22 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	David Miller <davem@...emloft.net>
Cc:	davej@...hat.com, netdev@...r.kernel.org
Subject: Re: appletalk oops.

On Friday 01 April 2011, David Miller wrote:
> appletalk: Fix OOPS in atalk_release().
> 
> Commit 60d9f461a20ba59219fdcdc30cbf8e3a4ad3f625 ("appletalk: remove
> the BKL") added a dereference of "sk" before checking for NULL in
> atalk_release().
> 
> Guard the code block completely, rather than partially, with the
> NULL check.
> 
> Reported-by: Dave Jones <davej@...hat.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>

Oops indeed.

The best excuse I have is that nobody who has access to a real
appletalk network stepped up to test it when I submitted the patches
and that I first suggested deleting the protocol instead because
I had no idea if my patch made any sense.

Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html