netdev - Re: [PATCH 12/14] ehea: Add some more ethtool operations and 64bit stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110406073536.71f4052d@kryten>
Date:	Wed, 6 Apr 2011 07:35:36 +1000
From:	Anton Blanchard <anton@...ba.org>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	Jesse Gross <jesse@...nel.org>
Cc:	leitao@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	michael@...erman.id.au
Subject: Re: [PATCH 12/14] ehea: Add some more ethtool operations and 64bit
 stats


Hi Ben, Jesse,

> > We can use the standard ethtool functions for set_tx_csum and
> > set_sg.
> 
> These are deprecated.  Please use the generic features interface
> instead.
> 
> > Also switch to using ndo_get_stats64 to get 64bit tx/rx stats.

and

> Thank you for removing the old LRO code but the vlan-specific GRO
> entry point is deprecated as well so please don't add new uses of it.

Thanks for the suggestions, I'll incorporate the changes and resubmit.

Anton
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html