netdev - Re: [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110406184059.GC6825@hmsreliant.think-freely.org>
Date:	Wed, 6 Apr 2011 14:40:59 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, therbert@...gle.com
Subject: Re: [PATCH] ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets

On Wed, Apr 06, 2011 at 08:37:44PM +0200, Eric Dumazet wrote:
> Le mercredi 06 avril 2011 à 11:27 -0700, David Miller a écrit :
> > From: Eric Dumazet <eric.dumazet@...il.com>
> > Date: Wed, 06 Apr 2011 20:23:08 +0200
> > 
> > > Le mercredi 06 avril 2011 à 11:17 -0700, David Miller a écrit :
> > >> From: Eric Dumazet <eric.dumazet@...il.com>
> > >> Date: Wed, 06 Apr 2011 20:07:33 +0200
> > >> 
> > >> > This is why we used on ipv4 :
> > >> > 
> > >> > if (inet_sk(sk)->inet_daddr)
> > >> > 	sock_rps_save_rxhash(sk, skb->rxhash);
> > >> > 
> > >> > 
> > >> > Only arm RFS on UDP if socket is bound to a given remote peer.
> > >> 
> > >> Agreed, Neil please make this change to your ipv6 code.
> > > 
> > > BTW, do you guys know if NFS is using RFS right now (if TCP transport is
> > > used) ?
> > 
> > It ought to be.  Are you specifically concerned that it might be
> > missing the rxhash setting calls because of the APIs it uses to
> > do socket I/O?
> > 
> > The SunRPC layer is a major user of tcp_read_sock(), for example.
> > 
> > But the packet processing will be done via the normal means,
> > therefore we'll hit tcp_v4_do_rcv() and therefore save the
> > rxhash.
> 
> Hmm, are multiple tcp sessions used between NFS client and server (One
> per cpu on client ?)
nope, its all nominally done per mount (i.e. all applications writing to a given
mount point will share the same socket).
Neil

> 
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html