netdev - Re: [PATCH net-next-2.6 02/12] skge: implement set_phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110406.143749.184826938.davem@davemloft.net>
Date:	Wed, 06 Apr 2011 14:37:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 02/12] skge: implement set_phys_id

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 04 Apr 2011 23:57:32 +0100

> On Mon, 2011-04-04 at 11:43 -0700, Stephen Hemminger wrote:
>> -		ms -= BLINK_MS;
>> +	switch (state) {
>> +	case ETHTOOL_ID_ACTIVE:
>> +		return -1;
> [...]
> 
> Must be -EINVAL.

I took care of this when I applied Stephen's patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html