netdev - Correct procedure to close an in-kernel TCP socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110406115545.GA16094@dezo.moloch.sk>
Date:	Wed, 6 Apr 2011 13:55:45 +0200
From:	Martin Lucina <mato@...elna.sk>
To:	netdev@...r.kernel.org
Cc:	Martin Sustrik <sustrik@...bpm.com>
Subject: Correct procedure to close an in-kernel TCP socket

Hi,

We're having some problems with code that uses in-kernel TCP sockets
created with sock_create_kern().

At the moment we are doing this when closing a socket:

	write_lock_bh(&s->sk->sk_callback_lock);
	s->sk->sk_state_change = old_sk_state_change;
	s->sk->sk_data_ready = old_sk_data_ready;
	s->sk->sk_write_space = old_sk_write_space;
	write_unlock_bh(&s->sk->sk_callback_lock);

        /* ... */

        sock_release(s);

We then see that at some point in the future our s->sk->sk_state_change
callback is still being called despite the code above restoring the
original values.

Is there something we're doing wrong? 

Thanks,

-mato
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html