netdev - Re: problem of "ipv4: revert Set rt->rt_iif more sanely on output routes."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110407.140333.189683738.davem@davemloft.net>
Date:	Thu, 07 Apr 2011 14:03:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hirofumi@...l.parknet.co.jp
Cc:	netdev@...r.kernel.org
Subject: Re: problem of "ipv4: revert Set rt->rt_iif more sanely on output
 routes."

From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Date: Thu, 07 Apr 2011 17:29:04 +0900

> I'm not sure
> 
> +	rth->rt_route_iif = 0;
> +	rth->rt_iif	= oldflp4->flowi4_oif ? : dev_out->ifindex;
> 
> is correct one or not. Please review.

I am pretty sure this is indeed correct.

In old code this read:

	rth->rt_iif	= oldflp->oif ? : dev_out->ifindex;

And rt->fl.iif was left without explicit setting, and thus left
as zero (dst_alloc() use to bzero entire rtable object).

So new code is equivalent and provides the necessary semantics.

I think your patch is correct and I will add it to net-2.6, thanks
again!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html