[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <C9C380CF.23F57%roprabhu@cisco.com>
Date: Thu, 07 Apr 2011 14:55:11 -0700
From: roprabhu <roprabhu@...co.com>
To: Michał Mirosław
<mirq-linux@...e.qmqm.pl>
CC: <netdev@...r.kernel.org>, Christian Benvenuti <benve@...co.com>,
Vasanthy Kolluri <vkolluri@...co.com>,
David Wang <dwang2@...co.com>
Subject: Re: [PATCH] net: enic: convert to hw_features
On 4/7/11 1:45 PM, "Michał Mirosław" <mirq-linux@...e.qmqm.pl> wrote:
> On Thu, Apr 07, 2011 at 12:52:45PM -0700, roprabhu wrote:
>> Thanks michal.
>>
>> One small comment below,
>>
>> On 4/7/11 5:43 AM, "Michał Mirosław" <mirq-linux@...e.qmqm.pl> wrote:
>>> As the driver uses GRO and not LRO, LRO settings are ignored anyway
>>> and are removed here to avoid confusion.
> [...]
>>> diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c
>>> index f111a37..6e5c635 100644
>>> --- a/drivers/net/enic/enic_res.c
>>> +++ b/drivers/net/enic/enic_res.c
>>> @@ -98,9 +98,9 @@ int enic_get_vnic_config(struct enic *enic)
>>> "vNIC MAC addr %pM wq/rq %d/%d mtu %d\n",
>>> enic->mac_addr, c->wq_desc_count, c->rq_desc_count, c->mtu);
>>> dev_info(enic_get_dev(enic), "vNIC csum tx/rx %d/%d "
>>> - "tso/lro %d/%d intr timer %d usec rss %d\n",
>>> + "tso %d intr timer %d usec rss %d\n",
>>> ENIC_SETTING(enic, TXCSUM), ENIC_SETTING(enic, RXCSUM),
>>> - ENIC_SETTING(enic, TSO), ENIC_SETTING(enic, LRO),
>>> + ENIC_SETTING(enic, TSO),
>>> c->intr_timer_usec, ENIC_SETTING(enic, RSS));
>>>
>> You are right about the driver using GRO and not LRO by default. But the
>> config entry from where enic gets this setting is still called LRO for
>> reasons out of the scope of the driver. Yes, I see that it can lead to
>> confusion. So, we will need to retain the ENIC_SETTING(enic, LRO) but fix
>> the name of that setting. Thanks for pointing this out. We will fix this
>> and any other changes if required and resubmit.
>
> I removed this part because now network core is always turning on GRO
> by default regardless of what driver sets in features at init time.
> That's on purpose, since GRO is purely a software feature.
>
> OTOH, if you want to forcibly disable GRO when LRO is not set in enic's
> config, then you can do so in ndo_fix_features callback.
>
Ok thanks michal.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists