netdev - RE: [PATCHv3 NEXT 1/1] net: ethtool support to configure number of channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 7 Apr 2011 04:41:54 -0500
From:	Amit Salecha <amit.salecha@...gic.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Ameen Rahman <ameen.rahman@...gic.com>,
	Anirban Chakraborty <anirban.chakraborty@...gic.com>
Subject: RE: [PATCHv3 NEXT 1/1] net: ethtool support to configure number of
 channels


> > +/* Channel type */
> > +/* Channel type should be pass in type field of ethtool_channels.
> > + * TYPE_ALL indicates set all channels to XX_count values.
> > + * TYPE_RX and TYPE_TX is to get and set RX and TX channels
> correspondingly.
> > + * TYPE_COMBINED is to set both RX and TX channels to rx_count and
> tx_count
> > + * correspondingly.
>
> That's not what I meant by 'combined'.  I meant a set of RX queues and
> TX queues (usually 1 of each) with an IRQ and maybe an event queue
> shared between them.  It should be possible for ethtool to distinguish
> combined channels, so it doesn't just report 'Invalid argument' if the
> user tries to set rx_count != tx_count.
>
> I think this requires that there are max_combined and combined_count
> (or
> similar) fields in struct ethtool_channels, so a driver that only
> supports combined channels can report max_rx = 0, max_tx = 0,
> max_combined = N.
>

I will add max_combined and combined_count field in ethtool_channels structure.

> > TYPE_OTHER is to configure other channel.
> > + */
> > +enum ethtool_channel_type {
> > +   ETH_CHAN_TYPE_ALL       = 0,
> > +   ETH_CHAN_TYPE_RX,
> > +   ETH_CHAN_TYPE_TX,
> > +   ETH_CHAN_TYPE_COMBINED,
> > +   ETH_CHAN_TYPE_OTHER,
> > +};
> [...]
>
> Really I'm not sure whether there's a need to be able to specify which
> channel counts are being changed.  ethtool or whatever utility is used
> can do ETHTOOL_GCHANNELS, modify channel counts, ETHTOOL_SCHANNELS and
> all the counts the user didn't want to change will be unchanged.  If
> you
> still think it is useful then use flags for the different channel types
> so there is no arbitrary restriction on which counts can be changed at
> the same time.
>

I will drop this enum, as we have defined all fields in ethtool_channels (rx, tx, other and combined).


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.