netdev - RE: [PATCH net-next 1/5] be2net: add rxhash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49395329523DD64492581B505F80C86D5A5BCD3949@EXMAIL.ad.emulex.com>
Date:	Thu, 7 Apr 2011 12:57:27 -0700
From:	<Ajit.Khaparde@...lex.Com>
To:	<eric.dumazet@...il.com>
CC:	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 1/5] be2net: add rxhash support

________________________________________
From: Eric Dumazet [eric.dumazet@...il.com]
Sent: Thursday, April 07, 2011 12:05 AM
To: Khaparde, Ajit
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/5] be2net: add rxhash support

> Le mercredi 06 avril 2011 à 23:07 -0500, Ajit Khaparde a écrit :
>> Add rxhash support,
>> Based on initial work by Eric Dumazet.
>>
>> Cc: Eric Dumazet <eric.dumazet@...il.com>
>> Signed-off-by: Ajit Khaparde <ajit.khaparde@...lex.com>
>> ---
>>  drivers/net/benet/be.h         |    5 +++++
>>  drivers/net/benet/be_ethtool.c |   13 +++++++++++++
>>  drivers/net/benet/be_main.c    |   17 ++++++++++++-----
>>  3 files changed, 30 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/benet/be.h b/drivers/net/benet/be.h
>> index 0899d91..8941b98 100644
>> --- a/drivers/net/benet/be.h
>> +++ b/drivers/net/benet/be.h
>> @@ -485,6 +485,11 @@ static inline void be_vf_eth_addr_generate(struct be_adapter *adapter, u8 *mac)
>>       memcpy(mac, adapter->netdev->dev_addr, 3);
>>  }
>>
> +static inline bool be_multi_rxq(struct be_adapter *adapter)

> static inline bool be_multi_rxq(const struct be_adapter *adapter)


>> +{
>> +     return (adapter->num_rx_qs > 1);

>        return adapter->num_rx_qs > 1;

>> +}
>> +

> Other parts seems fine, thanks !

Thanks Eric.

Dave, do you want me to respin patch or you can accomodate Eric's suggestion?

Thanks
-Ajit--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html