netdev - Re: ipv6: Add support for RTA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110407.132754.226758337.davem@davemloft.net>
Date:	Thu, 07 Apr 2011 13:27:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dwalter@...racuda.com
Cc:	netdev@...r.kernel.org
Subject: Re: ipv6: Add support for RTA_PREFSRC

From: Daniel Walter <dwalter@...racuda.com>
Date: Thu, 7 Apr 2011 11:23:57 +0200

> On Wed, 2011-04-06 at 18:37 -0700, David Miller wrote:
>> From: Daniel Walter <dwalter@...racuda.com>
>> Date: Mon, 4 Apr 2011 09:56:44 +0200
>> 
>> > On Fri, 2011-04-01 at 20:46 -0700, David Miller wrote:
>> >> You can't change the layout of "struct in6_rtmsg", as that structure
>> >> is explicitly exported to user space and changing it will break every
>> >> application out there.
>> > 
>> > Hi,
>> > 
>> > I've kicked support for setting the preferred source via ioctl,
>> > to keep "struct in6_rtmsg" untouched.
>> > This reduces the RTA_PREFSRC support to netlink only, unless
>> > we break the struct.
>> > 
>> > Do you see any other way around this problem?
>> 
>> This is fine, adding new feature support to deprecated things like
>> the ioctl routing calls is undesirable anyways.
>> 
>> Since you do the prefsrc extraction in at least two places, make a
>> helper function that does the whole "if prefsrc.plen use prefsrc, else
>> use ipv6_dev_get_saddr()"
>> 
>> This would be akin to ipv4's FIB_RES_PREFSRC
> Hi,
> 
> I've moved the extraction into a helper function as suggested and did
> some cleanup.

Daniel, please, when you submit new versions of patches do make a full
and complete resubmission.

This means, write a new email, provide a full commit message, proper
Subject, and Signed-off-by: lines.

Don't just reply to my request with a new patch, that doesn't work
and your changes won't get tracked properly.