netdev - Re: extending feature word.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110408100535.GB10565@rere.qmqm.pl>
Date:	Fri, 8 Apr 2011 12:05:35 +0200
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	linux-netdev <netdev@...r.kernel.org>,
	Ben Hutchings <bhutchings@...arflare.com>,
	David Miller <davem@...emloft.net>
Subject: Re: extending feature word.

On Fri, Apr 01, 2011 at 07:07:05PM -0700, Mahesh Bandewar wrote:
> Thanks for your comments on my loop-back patch. I was looking at the
> code today from the perspective of extending various "features" for
> word to an array of words and as Michael has pointed out, it's a huge
> change. So I'm thinking on the following lines
> (include/linux/netdevice.h)
> 
> +#define DEV_FEATURE_WORDS      2
> +#define LEGACY_FEATURE_WORD    0
>        /* currently active device features */
> -       u32                     features;
> +       u32                     features[DEV_FEATURE_WORDS];
>        /* user-changeable features */
> -       u32                     hw_features;
> +       u32                     hw_features[DEV_FEATURE_WORDS];
>        /* user-requested features */
> -       u32                     wanted_features;
> +       u32                     wanted_features[DEV_FEATURE_WORDS];
>        /* VLAN feature mask */
> -       u32                     vlan_features;
> +       u32                     vlan_features[DEV_FEATURE_WORDS];

Hmm. There might be no point in making features field an array.
This gives us nothing really. Maybe just add features_2 or similar?
If we ever get to the point there need to be more than two words for
features we can think of some abstraction layer then.

Or we might add a new field and put there NETIF_F_LLTX, NETIF_F_HIGHDMA
and others that are not user changeable ever. Those don't need dynamic
propagation to slave devices (e.g. VLAN) and wanted/hw_features for them.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html