netdev - Re: [PATCH] net: sky2: convert to hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110410135007.7a4eccdf@nehalam>
Date:	Sun, 10 Apr 2011 13:50:07 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: sky2: convert to hw_features

On Sun, 10 Apr 2011 15:13:21 +0200 (CEST)
Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote:

> @@ -4620,18 +4574,21 @@ static __devinit struct net_device *sky2_init_netdev(struct sky2_hw *hw,
>  
>  	sky2->port = port;
>  
> -	dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG
> -		| NETIF_F_TSO | NETIF_F_GRO;
> +	dev->hw_features |= NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO;
>  

You lost GRO flag in the conversion. Since code calls gro_receive,
this is necessary.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html