netdev - Re: [PATCHv2 NEXT 6/8] qlcnic: sparse warning fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1302562801.5282.576.camel@localhost>
Date:	Tue, 12 Apr 2011 00:00:01 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Amit Kumar Salecha <amit.salecha@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	ameen.rahman@...gic.com, anirban.chakraborty@...gic.com,
	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
Subject: Re: [PATCHv2 NEXT 6/8] qlcnic: sparse warning fixes

On Mon, 2010-10-04 at 08:14 -0700, Amit Kumar Salecha wrote:
> From: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
> 
> Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@...gic.com>
> ---
>  drivers/net/qlcnic/qlcnic_ctx.c  |   12 ++++++------
>  drivers/net/qlcnic/qlcnic_main.c |   10 +++++-----
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/qlcnic/qlcnic_ctx.c b/drivers/net/qlcnic/qlcnic_ctx.c
> index a4c4d09..75e3b19 100644
> --- a/drivers/net/qlcnic/qlcnic_ctx.c
> +++ b/drivers/net/qlcnic/qlcnic_ctx.c
> @@ -742,15 +742,15 @@ int qlcnic_get_pci_info(struct qlcnic_adapter *adapter,
>  
>  	if (err == QLCNIC_RCODE_SUCCESS) {
>  		for (i = 0; i < QLCNIC_MAX_PCI_FUNC; i++, npar++, pci_info++) {
> -			pci_info->id = le32_to_cpu(npar->id);
> -			pci_info->active = le32_to_cpu(npar->active);
> -			pci_info->type = le32_to_cpu(npar->type);
> +			pci_info->id = le16_to_cpu(npar->id);
> +			pci_info->active = le16_to_cpu(npar->active);
> +			pci_info->type = le16_to_cpu(npar->type);
>  			pci_info->default_port =
> -				le32_to_cpu(npar->default_port);
> +				le16_to_cpu(npar->default_port);
>  			pci_info->tx_min_bw =
> -				le32_to_cpu(npar->tx_min_bw);
> +				le16_to_cpu(npar->tx_min_bw);
>  			pci_info->tx_max_bw =
> -				le32_to_cpu(npar->tx_max_bw);
> +				le16_to_cpu(npar->tx_max_bw);
[...]

It looks like this function was broken on big-endian systems.  The
commit message should say that you are fixing a bug, not just that some
unspecified 'sparse warning[s]' (that alerted you to the bug) were
fixed.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html