netdev - Re: [net-next-2.6 RFC PATCH] ethtool: allow custom interval for physical identification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110411162601.6686f169@nehalam>
Date:	Mon, 11 Apr 2011 16:26:01 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Bruce Allan <bruce.w.allan@...el.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 RFC PATCH] ethtool: allow custom interval for
 physical identification

On Mon, 11 Apr 2011 16:16:35 -0700
Bruce Allan <bruce.w.allan@...el.com> wrote:

> When physical identification of an adapter is done by toggling the
> mechanism on and off through software utilizing the .set_phys_id operation,
> it is done with a fixed duration for both on and off states.  Some drivers
> may want to set a custom duration for the on/off intervals.  This patch
> changes the API so the return code from the driver's entry point can
> specify the interval duration as a positive number; -EINVAL is still
> allowed in order to use the default single on/off interval per second.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>

IMHO this is -EOVERKILL.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html