netdev - Re: [PATCH net-next-2.6 1/2] gianfar: Clean up implementation of RX network flow classification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110411.132909.232734437.davem@davemloft.net>
Date:	Mon, 11 Apr 2011 13:29:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH net-next-2.6 1/2] gianfar: Clean up implementation of
 RX network flow classification

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Sat, 09 Apr 2011 00:45:11 +0100

> This code was cribbed from niu, so gfar_set_hash_opts() begins by
> converting the ethtool flow class code into a class code for Sun
> Neptune hardware, then does the same thing again for the hardware it's
> really dealing with.  It may also return -1 (-EPERM) for some
> unhandled ethtool flow class codes.
> 
> Remove the useless code and definitions, and fix the error code.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
> This isn't even compile-tested, since it can only be built for some
> PowerPC SoCs.  Could someone on ppc-dev check that this won't break the
> driver?

I'm applying this, it looks so trivial to me that I'm willing to take
the build risk :-)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html