netdev - Re: [PATCH 1/1] ipv6: RTA_PREFSRC support for ipv6 route source address selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110412.151659.15244967.davem@davemloft.net>
Date:	Tue, 12 Apr 2011 15:16:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dwalter@...racuda.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ipv6: RTA_PREFSRC support for ipv6 route source
 address selection

From: David Miller <davem@...emloft.net>
Date: Tue, 12 Apr 2011 15:05:11 -0700 (PDT)

> From: Daniel Walter <dwalter@...racuda.com>
> Date: Mon, 11 Apr 2011 09:03:29 +0200
> 
>> [ipv6] Add support for RTA_PREFSRC
>> 
>> This patch allows a user to select the preferred source address
>> for a specific IPv6-Route. It can be set via a netlink message
>> setting RTA_PREFSRC to a valid IPv6 address which must be
>> up on the device the route will be bound to.
>> 
>> 
>> Signed-off-by: Daniel Walter <dwalter@...racuda.com>
> 
> Ok, I can live with this, applied, thanks!

Sorry, I had to revert.

Please fix this warning, test your patch, and resubmit it.

net/ipv6/ip6_output.c: In function ‘ip6_dst_lookup_tail’:
net/ipv6/ip6_output.c:936: warning: passing argument 3 of ‘ip6_route_get_saddr’ from incompatible pointer type
include/net/ip6_route.h:87: note: expected ‘struct in6_addr *’ but argument is of type ‘struct dst_entry **’

Thanks.