netdev - Re: Kernel panic when using bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1302627281.3233.70.camel@edumazet-laptop>
Date:	Tue, 12 Apr 2011 18:54:41 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Bandan Das <bandan.das@...atus.com>
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	Jan Lübbe <jluebbe@...ian.org>,
	Scot Doyle <lkml@...tdoyle.com>,
	Hiroaki SHIMODA <shimoda.hiroaki@...il.com>,
	netdev@...r.kernel.org
Subject: Re: Kernel panic when using bridge

Le mardi 12 avril 2011 à 12:45 -0400, Bandan Das a écrit :
> On  0, Eric Dumazet <eric.dumazet@...il.com> wrote:
> > Le mardi 12 avril 2011 à 09:20 -0700, Stephen Hemminger a écrit :
> > 
> > > I think the confusion is that IPCB(skb) is not the IP header but
> > > scratch space used during IP header processing. Before the sanitize
> > > patch the CB was cleared.
> > > 
> > > Acked-by: Stephen Hemminger <shemminger@...tta.com>
> > 
> > Should we clear it also in br_nf_dev_queue_xmit(), since we did this
> > prior to commit 462fb2af9788a8 ?
> > 
> > Thanks !
> > 
> Wouldn't that clear out any valid IP options if it were there ? I think
> that was the whole point of adding br_parse_ip_options :
> 
> /* BUG: Should really parse the IP options here. */
> memset(IPCB(skb), 0, sizeof(struct inet_skb_parm));
> 
>  
> 

Oh yes, I missed br_nf_dev_queue_xmit() called br_parse_ip_options() and
not ip_options_compile()

I'll submit an official patch, thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html