netdev - Re: [net-next PATCH 1/3] vxge: always enable hardware time stamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110412.110151.71117421.davem@davemloft.net>
Date:	Tue, 12 Apr 2011 11:01:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jdmason@...zu.us
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next PATCH 1/3] vxge: always enable hardware time stamp

From: Jon Mason <jdmason@...zu.us>
Date: Tue, 12 Apr 2011 10:36:06 -0500

> On Sun, Apr 10, 2011 at 06:58:45PM -0700, David Miller wrote:
>> From: Jon Mason <jdmason@...zu.us>
>> Date: Fri,  8 Apr 2011 16:11:21 -0500
>> 
>> > Hardware time stamp calculation can only be enabled by the privileged
>> > function. Enable it always by default and simply use the ethtool
>> > interface to set a flag to indicate whether or not the respective
>> > function driver should indicate the timestamp along with the received
>> > packet.
>> > 
>> > Also, make certain fields in vxge_hw_device_config bit-fields to reduce
>> > the size of the struct.
>> > 
>> > Signed-off-by: Jon Mason <jdmason@...zu.us>
>> 
>> Doesn't this have some performance or latency impact?
> 
> It is all done in hardware by replacing the CRC with the HWTS value.
> So, no perf or latency issues there.  It still only handles the HWTS
> in receive if it is enabled in software via the ioctl. 

Ok, thanks for the clarification, I'll apply this patch set.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html