netdev - Re: [PATCH] s2io: Fix warnings due to -Wunused-but-set-variable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110412.112114.104057205.davem@davemloft.net>
Date:	Tue, 12 Apr 2011 11:21:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jdmason@...zu.us
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] s2io: Fix warnings due to -Wunused-but-set-variable.

From: Jon Mason <jdmason@...zu.us>
Date: Tue, 12 Apr 2011 11:00:04 -0500

> On Mon, Apr 11, 2011 at 04:01:43PM -0700, David Miller wrote:
>> 
>> Most of these are cases where we are trying to read back a register
>> after a write to ensure completion.
>> 
>> Simply pre-fixing the readl() or readq() with "(void)" is sufficient
>> because these are volatile operations and the compiler cannot eliminate
>> them just because no real assignment takes place.
>> 
>> The case of free_rxd_blk()'s assignments to "struct buffAdd *ba" is a
>> real spurious assignment as this variable is completely otherwise
>> unused.
>> 
>> Signed-off-by: David S. Miller <davem@...emloft.net>
> Acked-by: Jon Mason <jdmason@...zu.us>

Thanks for reviewing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html