netdev - Re: [PATCH net-next-2.6 v3 2/3] sctp: Add ASCONF operation on the single-homed host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <204CE840-C282-4B12-8015-37AD00386133@sfc.wide.ad.jp>
Date:	Wed, 13 Apr 2011 10:32:27 +0900
From:	Michio Honda <micchie@....wide.ad.jp>
To:	Wei Yongjun <yjwei@...fujitsu.com>
Cc:	netdev@...r.kernel.org, lksctp-developers@...ts.sourceforge.net
Subject: Re: [PATCH net-next-2.6 v3 2/3] sctp: Add ASCONF operation on the single-homed host

Hi, 

>> 
>> 
>> 	if (t)
>> 		asoc->peer.retran_path = t;
>> +	else if (unconfirmed)
>> +		asoc->peer.retran_path = t = unconfirmed;
>> 
>> 	SCTP_DEBUG_PRINTK_IPADDR("sctp_assoc_update_retran_path:association"
>> 				 " %p addr: "
> 
> since we can not select unconfirmed transports for retransmission,
> this part is not correct. the specification forbids this due to security
> issues.
> Not sure whether you hit this bug: remove transport and left only
> one unconfirmed transport, it may cause oops while retransmit.
> I will send other patch to fix it first.
Yes, I added these 2 lines to avoid panic, I'll remove after your patch.  

Thanks,
- Michio
> 
> 
> ...snip...
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html