[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110414015310.GC5167@verge.net.au>
Date: Thu, 14 Apr 2011 09:53:11 +0800
From: Simon Horman <horms@...ge.net.au>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: Vasiliy Kulikov <segoon@...nwall.com>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
Pavel Kankovsky <peak@...o.troja.mff.cuni.cz>,
Solar Designer <solar@...nwall.com>,
Kees Cook <kees.cook@...onical.com>,
Dan Rosenberg <dan.j.rosenberg@...il.com>,
Eugene Teo <eugene@...hat.com>,
Nelson Elhage <nelhage@...lice.com>,
"David S. Miller" <davem@...emloft.net>,
Alexey Kuznetsov <kuznet@....inr.ac.ru>,
Pekka Savola <pekkas@...core.fi>,
James Morris <jmorris@...ei.org>,
Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH] net: ipv4: add IPPROTO_ICMP socket kind
On Wed, Apr 13, 2011 at 01:29:49PM +0300, Alexey Dobriyan wrote:
> On Sat, Apr 9, 2011 at 1:15 PM, Vasiliy Kulikov <segoon@...nwall.com> wrote:
[snip]
> > @@ -714,8 +790,22 @@ static __net_init int ipv4_sysctl_init_net(struct net *net)
> > &net->ipv4.sysctl_icmp_ratemask;
> > table[6].data =
> > &net->ipv4.sysctl_rt_cache_rebuild_count;
> > +#ifdef CONFIG_IP_PING
> > + table[7].data =
> > + &net->ipv4.sysctl_ping_group_range;
> > +#endif
>
> Now I understand it's not related, but next sysctl will have
> "table[8].data = ..." line which is off-by-one if CONFIG_IP_PING=n.
Another good reason for the code to be non-optoinal
and not to have CONFIG_IP_PING.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists