netdev - Re: [net-next-2.6 RFC PATCH v3] ethtool: allow custom interval for physical identification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110414.211934.193722116.davem@davemloft.net>
Date:	Thu, 14 Apr 2011 21:19:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	bruce.w.allan@...el.com, netdev@...r.kernel.org,
	sathya.perla@...lex.com, subbu.seetharaman@...lex.com,
	ajit.khaparde@...lex.com, mchan@...adcom.com, eilong@...adcom.com,
	divy@...lsio.com, pcnet32@...ntier.com, jdmason@...zu.us,
	linux-net-drivers@...arflare.com, shodgson@...arflare.com,
	shemminger@...ux-foundation.org, mcarlson@...adcom.com
Subject: Re: [net-next-2.6 RFC PATCH v3] ethtool: allow custom interval for
 physical identification

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Fri, 15 Apr 2011 02:26:25 +0100

> On Wed, 2011-04-13 at 16:09 -0700, Bruce Allan wrote:
>> When physical identification of an adapter is done by toggling the
>> mechanism on and off through software utilizing the set_phys_id operation,
>> it is done with a fixed duration for both on and off states.  Some drivers
>> may want to set a custom duration for the on/off intervals.  This patch
>> changes the API so the return code from the driver's entry point when it
>> is called with ETHTOOL_ID_ACTIVE can specify the frequency at which to
>> cycle the on/off states, and updates the drivers that have already been
>> converted to use the new set_phys_id and use the synchronous method for
>> identifying an adapter.
>> 
>> The physical identification frequency set in the updated drivers is based
>> on how it was done prior to the introduction of set_phys_id.
>> 
>> Compile tested only.  Also fixes a compiler warning in sfc.
>> 
>> v2: drivers do not return -EINVAL for ETHOOL_ID_ACTIVE
>> v3: fold patchset into single patch and cleanup per Ben's feedback
>> 
>> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
>> Cc: Ben Hutchings <bhutchings@...arflare.com>
> [...]
> Acked-by: Ben Hutchings <bhutchings@...arflare.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html