lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110417.233053.70188684.davem@davemloft.net>
Date:	Sun, 17 Apr 2011 23:30:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jon.mason@...i.com
Cc:	mirq-linux@...e.qmqm.pl, netdev@...r.kernel.org, gallatin@...i.com,
	brice@...i.com
Subject: Re: [PATCH] net: myri10ge: convert to hw_features

From: Jon Mason <jon.mason@...i.com>
Date: Fri, 15 Apr 2011 13:29:22 -0500

> On Fri, Apr 15, 2011 at 04:50:50PM +0200, Michaİİ Mirosİİaw wrote:
>> Signed-off-by: Michaİİ Mirosİİaw <mirq-linux@...e.qmqm.pl>
>> ---
>>  drivers/net/myri10ge/myri10ge.c |   66 +++++++-------------------------------
>>  1 files changed, 12 insertions(+), 54 deletions(-)
>> 
>> diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
>> index 1446de5..a48eb92 100644
>> --- a/drivers/net/myri10ge/myri10ge.c
>> +++ b/drivers/net/myri10ge/myri10ge.c
>> @@ -205,7 +205,6 @@ struct myri10ge_priv {
>>  	int tx_boundary;	/* boundary transmits cannot cross */
>>  	int num_slices;
>>  	int running;		/* running?             */
>> -	int csum_flag;		/* rx_csums?            */
> 
> Get rid of MXGEFW_FLAGS_CKSUM in drivers/net/myri10ge/myri10ge_mcp.h,
> as this was the only thing using it.
 ...
> ethtool_op_set_tso does not support TSO6.  This would remove the
> enable/disable of that feature.

Michaİİ please fix these issues and resubmit this patch, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ