netdev - Re: [patch net-next-2.6] bonding: move processing of recv handlers into handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110420113043.GD2998@psychotron.brq.redhat.com>
Date:	Wed, 20 Apr 2011 13:30:44 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, kaber@...sh.net, fubar@...ibm.com,
	nicolas.2p.debian@...il.com, andy@...yhouse.net
Subject: Re: [patch net-next-2.6] bonding: move processing of recv handlers
 into handle_frame()

Tue, Apr 19, 2011 at 04:02:32PM CEST, eric.dumazet@...il.com wrote:
>Le mardi 19 avril 2011 à 15:48 +0200, Jiri Pirko a écrit :
>> Since now when bonding uses rx_handler, all traffic going into bond
>> device goes thru bond_handle_frame. So there's no need to go back into
>> bonding code later via ptype handlers. This patch converts
>> original ptype handlers into "bonding receive probes". These functions
>> are called from bond_handle_frame and they are registered per-mode.
>> 
>> Note that vlan packets are also handled because they are always untagged
>> thanks to vlan_untag()
>> 
>> Note that this also allows arpmon for eth-bond-bridge-vlan topology.
>> 
>> Signed-off-by: Jiri Pirko <jpirko@...hat.com>
>
>
>
>>  			}
>> diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
>> index 6126c6a..85fb822 100644
>> --- a/drivers/net/bonding/bonding.h
>> +++ b/drivers/net/bonding/bonding.h
>> @@ -226,6 +226,8 @@ struct bonding {
>>  	struct   slave *primary_slave;
>>  	bool     force_primary;
>>  	s32      slave_cnt; /* never change this value outside the attach/detach wrappers */
>> +	void     (*recv_probe)(struct sk_buff *, struct bonding *,
>> +			       struct slave *);
>>  	rwlock_t lock;
>>  	rwlock_t curr_slave_lock;
>>  	s8       kill_timers;
>
>
>Any performance numbers ?

Getting these. (Hitting nasty panic on another machine running pktgen @
vlan dev).

>
>I am asking because recv_probe sits in a often dirtied cache line...
>
>It would be nice to separate rx & tx path needs
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html