netdev - Re: [PATCH] net: make WARN_ON in dev_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1303449113.13893.2.camel@edumazet-laptop>
Date:	Fri, 22 Apr 2011 07:11:53 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: make WARN_ON in dev_disable_lro() useful

Le vendredi 22 avril 2011 à 00:42 +0200, Michał Mirosław a écrit :
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
>  net/core/dev.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 3871bf6..3421184 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1315,7 +1315,8 @@ void dev_disable_lro(struct net_device *dev)
>  		return;
>  
>  	__ethtool_set_flags(dev, flags & ~ETH_FLAG_LRO);
> -	WARN_ON(dev->features & NETIF_F_LRO);
> +	if (unlikely(dev->features & NETIF_F_LRO))
> +		netdev_WARN(dev, "failed to disable LRO!\n");
>  }
>  EXPORT_SYMBOL(dev_disable_lro);
>  

Yes, as suggested one month ago
http://permalink.gmane.org/gmane.linux.network/189951

Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

BTW, using unlikely() or likely() in slowpath is not exactly useful,
unless its integrated in macro (WARN_... )





--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html