netdev - Re: [PATCH] netfilter/IPv6: fix DSCP mangle code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110422.000838.193727308.davem@davemloft.net>
Date:	Fri, 22 Apr 2011 00:08:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fernando@....ntt.co.jp
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
	jengelh@...ozas.de, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] netfilter/IPv6: fix DSCP mangle code

From: Fernando Luis Vazquez Cao <fernando@....ntt.co.jp>
Date: Fri, 22 Apr 2011 16:02:39 +0900

> The mask indicates the bits one wants to zero out, so it needs to be
> inverted before applying to the original TOS field.
> 
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@....ntt.co.jp>
> ---

Netfilter patches should be sent to the netfilter developer
list, CC:'d

> diff -urNp linux-2.6.37-orig/net/netfilter/xt_DSCP.c linux-2.6.37/net/netfilter/xt_DSCP.c
> --- linux-2.6.37-orig/net/netfilter/xt_DSCP.c	2011-01-05 09:50:19.000000000 +0900
> +++ linux-2.6.37/net/netfilter/xt_DSCP.c	2011-04-21 16:01:25.801890733 +0900
> @@ -99,7 +99,7 @@ tos_tg6(struct sk_buff *skb, const struc
>  	u_int8_t orig, nv;
>  
>  	orig = ipv6_get_dsfield(iph);
> -	nv   = (orig & info->tos_mask) ^ info->tos_value;
> +	nv   = (orig & ~info->tos_mask) ^ info->tos_value;
>  
>  	if (orig != nv) {
>  		if (!skb_make_writable(skb, sizeof(struct iphdr)))
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html