netdev - Re: [PATCH v3 08/27] HFI: DD request framework and first HFI DD request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110421.171247.28810365.davem@davemloft.net>
Date:	Thu, 21 Apr 2011 17:12:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dykmanj@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, piyushc@...ux.vnet.ibm.com,
	fcchang@...ux.vnet.ibm.com, wscadden@...ux.vnet.ibm.com,
	winstonc@...ux.vnet.ibm.com, sakolish@...ux.vnet.ibm.com,
	jian@...ux.vnet.ibm.com, clsoto@...ux.vnet.ibm.com,
	sjsheppa@...ux.vnet.ibm.com
Subject: Re: [PATCH v3 08/27] HFI: DD request framework and first HFI DD
 request

From: dykmanj@...ux.vnet.ibm.com
Date: Thu, 21 Apr 2011 17:38:38 -0400

> +#include <linux/vermagic.h>

I think this has been brought up by others, but please do not include
kernel version headers in your driver.

Not only should it be completely unnecessary upstream, it also makes
your driver get rebuilt every single make of the tree, which drivers
some of us crazy :-)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html