netdev - Re: [PATCH] net: allow user to change NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Apr 2011 18:48:03 +0200
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: allow user to change NETIF_F_HIGHDMA

On Fri, Apr 22, 2011 at 09:38:50AM -0700, Stephen Hemminger wrote:
> On Fri, 22 Apr 2011 18:31:16 +0200 (CEST)
> Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote:
> > NETIF_F_HIGHDMA is like any other TX offloads, so allow user to toggle it.
> > This is needed later for bridge and bonding convertsion to hw_features.
> This was meant to be a hidden flag that that reflects capability of
> hardware. Do yo really mean to allow user to disable it via ethtool?

Yes. BTW, you can say the same about e.g. NETIF_F_SG. There's no harm in
user being able to disable HIGHDMA (except obvious performance issue when
disabled -- as with other TX offloads).

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html